1169233 - [gtk3] Disabled menu items are not greyed out

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Mike Hommey [:glandium]]

For example, press Alt or F10 to open the menu from the menu bar, In "Edit", you should expect "Undo", "Redo", "Cut", "Copy" and "Delete" to be disabled in many cases. You can't select them, as expected, but they have the same text color as other menu items.

Comment 1

[Mike Hommey [:glandium]]

The corresponding CSS is:
http://hg.mozilla.org/mozilla-central/file/baa9c64fea6f/toolkit/themes/linux/global/menu.css#l36

So GrayText resolves to the same as MenuText.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mike Hommey [:glandium] from comment #1)
> The corresponding CSS is:
> http://hg.mozilla.org/mozilla-central/file/baa9c64fea6f/toolkit/themes/linux/
> global/menu.css#l36
> 
> So GrayText resolves to the same as MenuText.
So here we come:

http://mxr.mozilla.org/mozilla-central/source/widget/gtk/nsLookAndFeel.cpp#244

244     case eColorID_graytext: // disabled text in windows, menus, etc.
245     case eColorID_inactivecaptiontext: // text in inactive window caption
246         gtk_style_context_get_color(mBackgroundStyle, 
247                                     GTK_STATE_FLAG_INSENSITIVE, &gdk_color);
248         aColor = GDK_RGBA_TO_NS_RGBA(gdk_color);
249         break;

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

Pick up menu label widget to fetch inactive (gray) color.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8012d33b7c71

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b47a3214540

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5b47a3214540